fix: keep pipes and backticks in checked values from breaking the table - #266
fix: keep pipes and backticks in checked values from breaking the table#266shenxianpeng wants to merge 1 commit into
Conversation
Commit Check✅ All 5 checks passed Show all 5 checkscommit-check 2.14.0 · Rules reference |
|
Warning Review limit reached
Next review available in: 43 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. 📝 WalkthroughWalkthroughReports now render every scope with status, checked value, and rule information. Passing commit rows beyond five are folded. Skipped and partial-skip results receive explicit verdicts. Tests and documentation reflect the new output. ChangesReport rendering and verdicts
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@main.py`:
- Around line 568-573: Update main.py lines 568-573 in _table_cell_escape to
choose a code-span delimiter longer than the longest backtick run in the escaped
text, while preserving pipe escaping; update main.py lines 635-638 to format
value_display with this safe code-span helper; add the regression case in
main_test.py lines 831-834 for a value such as “fix: `quoted`”.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
3127748 to
7e9c578
Compare
A commit subject is arbitrary text: a | inside a table cell ended the cell, and a backtick ended the single-backtick code span and rendered the rest of the row as markdown. The value cell now escapes pipes and grows the span delimiter past the longest backtick run in the value, with padding spaces when it starts or ends with one.
7e9c578 to
b1614fa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
==========================================
+ Coverage 92.38% 92.52% +0.14%
==========================================
Files 1 1
Lines 420 428 +8
==========================================
+ Hits 388 396 +8
Misses 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Originally an all-scope table redesign— scope narrowed after review: the redesigned table grew with the number of commits in the PR and duplicated the collapsible details block line for line, so the layout stays exactly as it is today. What remains are the two rendering bugs found along the way:|in a checked value (a commit subject is arbitrary text) ended the table cell and broke the row layout. Pipes are now escaped.Three regression tests cover the pipe, an embedded backtick, and a trailing backtick. No visual or structural change to the report — success, failure and skipped states render as before.