Skip to content

test(resolution): close SQLite handles before rmSync so Windows teardown doesn't EPERM #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JOhnsonKC201 wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −4
Open

test(resolution): close SQLite handles before rmSync so Windows teardown doesn't EPERM #901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions __tests__/resolution.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1964,6 +1964,7 @@ func main() {
// feature can't silently regress to a no-op in the indexing flow.
it('connects #include to the real header file via include-dir scan (end-to-end)', async () => {
const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-cpp-e2e-'));
let db: DatabaseConnection | undefined;
try {
fs.mkdirSync(path.join(tempProject, 'include'), { recursive: true });
fs.mkdirSync(path.join(tempProject, 'src'), { recursive: true });
Expand All @@ -1986,7 +1987,7 @@ func main() {
// The `#include "utils.h"` edge should target the real
// `include/utils.h` file node — not a floating `import` node
// living inside main.cpp.
const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
const rows = db.getDb().prepare(`
select dst.kind as dstKind, dst.file_path as dstPath
from edges e
Expand All @@ -2006,6 +2007,12 @@ func main() {
);
expect(stdlibFile).toBeUndefined();
} finally {
// Close every SQLite handle on tempProject before removing it — the
// local reader AND the CodeGraph instance (afterEach's cg.destroy()
// runs too late, after this rmSync). On Windows an open handle locks
// the file and rmSync throws EPERM; POSIX silently unlinks it.
db?.close();
cg?.close();
fs.rmSync(tempProject, { recursive: true, force: true });
}
});
Expand Down Expand Up @@ -2034,6 +2041,7 @@ func main() {

it('resolves require_once to a file→file imports edge (#660)', async () => {
const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-php-e2e-'));
let db: DatabaseConnection | undefined;
try {
fs.mkdirSync(path.join(tempProject, 'src'), { recursive: true });
fs.writeFileSync(
Expand All @@ -2050,7 +2058,7 @@ func main() {
// reporter's repro: page.php's `require_once("lib.php")` must resolve
// to the real src/lib.php file node — a file→file `imports` edge, so
// callers(lib.php) now includes page.php.
const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
const rows = db.getDb().prepare(`
select dst.kind as dstKind, dst.file_path as dstPath
from edges e
Expand All @@ -2065,12 +2073,17 @@ func main() {
);
expect(resolved, 'page.php → src/lib.php imports edge missing').toBeDefined();
} finally {
// Close the local reader and the CodeGraph instance before rmSync so
// Windows doesn't EPERM on a still-open SQLite handle (see above).
db?.close();
cg?.close();
fs.rmSync(tempProject, { recursive: true, force: true });
}
});

it('resolves a subdirectory include path to the correct file (#660)', async () => {
const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-php-subdir-'));
let db: DatabaseConnection | undefined;
try {
fs.mkdirSync(path.join(tempProject, 'inc'), { recursive: true });
fs.writeFileSync(
Expand All @@ -2084,7 +2097,7 @@ func main() {

cg = await CodeGraph.init(tempProject, { index: true });

const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
const rows = db.getDb().prepare(`
select dst.kind as dstKind, dst.file_path as dstPath
from edges e
Expand All @@ -2099,12 +2112,17 @@ func main() {
'index.php → inc/db.php imports edge missing'
).toBeDefined();
} finally {
// Close the local reader and the CodeGraph instance before rmSync so
// Windows doesn't EPERM on a still-open SQLite handle (see above).
db?.close();
cg?.close();
fs.rmSync(tempProject, { recursive: true, force: true });
}
});

it('does not mis-connect an unresolvable include to a same-named file elsewhere (#660)', async () => {
const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-php-misresolve-'));
let db: DatabaseConnection | undefined;
try {
// app/page.php's `require "inc/db.php"` resolves relative to app/, where
// inc/db.php does NOT exist. A same-named lib/inc/db.php exists elsewhere
Expand All @@ -2123,7 +2141,7 @@ func main() {

cg = await CodeGraph.init(tempProject, { index: true });

const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
const rows = db.getDb().prepare(`
select dst.kind as dstKind, dst.file_path as dstPath
from edges e
Expand All @@ -2138,6 +2156,10 @@ func main() {
'app/page.php must NOT mis-connect to unrelated lib/inc/db.php'
).toBeUndefined();
} finally {
// Close the local reader and the CodeGraph instance before rmSync so
// Windows doesn't EPERM on a still-open SQLite handle (see above).
db?.close();
cg?.close();
fs.rmSync(tempProject, { recursive: true, force: true });
}
});
Expand Down