A trophy shelf, because he can't pick up a card#13
Closed
codewithwan wants to merge 2 commits into
Closed
Conversation
Achievements as objects, not a grid of boxes with letter-ranks in them. That grid is bento with a medal on it, and bento is a language from someone else's app — it looked wrong here for the same reason it looked wrong the first time. The engine draws crates, ovens, cakes and rockets. He can hold those. Cups fit that world; cards don't. Same shape as the stats readout, and for the same reason: he steps aside, the shelf drops in beside him, cups land one at a time while he watches, it folds away, he strolls back. The engine builds the shelf and says which cups have landed; the labels are the reader's numbers, so the renderer draws them. Four cups, and that's arithmetic. He occupies eleven of the stage's thirty-two cells; nineteen are left; a cup is three cells and needs one of air. Four fits at 132px a slot, which is eight glyphs, which is 'commits' with room. Five fits nothing legible at any spacing — measured, after the first draft rendered them as a gold fence with the labels reading 'commitprivaterepos'. Three tests hold the geometry: he never teleports, every cup is up before the shelf folds, and the shelf is gone before he walks home — home is underneath the labels, and the first cut had him walking through his own text. The numbers worth showing are already there: GitHub reports 1,671 restricted contributions against 384 public. The wall can only draw the 384.
Owner
Author
|
Closing this — it's a second way to do a job the The readout, with zero new code: Five slots, legible, already shipped. The shelf managed four, and its cups rendered as gold T's — because a trophy needs a bowl, handles, a stem and a base, and none of that exists at three cells. Measured: a readable cup is 5–6 cells, which fits two or three, not four. I picked the slot count first and shrank the art to fit, which is backwards. What the trophies added over the readout was a gold shape. That isn't worth 250 lines and a fifth of the stage. The one number worth having — GitHub reports 1,671 restricted contributions against 384 public — is a config line today: "stats": ["commits:384", "private:1671", "repos:23", "reviews:4", "PRs:13"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Achievements as objects, not a grid of boxes with letter-ranks in them.
That grid is bento with a medal on it, and bento is a language from someone
else's app. The engine draws crates, ovens, cakes and rockets. He can hold
those. Cups fit that world; cards don't.
Same shape as the stats readout, for the same reason: he steps aside, the shelf
drops in beside him, cups land one at a time while he watches, it folds away, he
strolls back. The engine builds the shelf and says which cups have landed; the
labels are the reader's numbers, so the renderer draws them.
Four cups, and that's arithmetic
He occupies 11 of the stage's 32 cells. Nineteen are left. A cup is three
cells and needs one of air.
commitsfitsMeasured after the first draft rendered them as a gold fence with the labels
reading
commitprivaterepos.Tests hold the geometry
shift_at(0) == -6, which breaks thereel's seam, and the test caught it before I'd looked at a single frame
and the first cut walked him through his own text
The number worth showing is already there
GitHub reports 1,671 restricted contributions against 384 public. The
contribution wall can only ever draw the 384.
Sample:
assets/scene-trophies.gif— "384 in public this year" → "and 1,671you can't see".