refactor: replace anonymous class with bound closure in PropertiesTrait - #10504
Open
paulbalandan wants to merge 1 commit into
Open
refactor: replace anonymous class with bound closure in PropertiesTrait#10504paulbalandan wants to merge 1 commit into
PropertiesTrait#10504paulbalandan wants to merge 1 commit into
Conversation
datamweb
approved these changes
Aug 29, 2026
datamweb
left a comment
Contributor
There was a problem hiding this comment.
This approach looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This one needs a bit of decision.
This refactors
PropertiesTrait::getPublicProperties()to use a bound Closure instead of an anonymous class in order to delete the 1 remainingmissingType.iterableValueerror. The other solution was to use reflection similar togetNonPublicProperties()approach, but here's the bench:200k iterations each, on an object with 5 public + 1 protected + 1 private property:
Bound closure is ~26% slower than the anonymous class but ~3.5x faster than reflection.
Checklist: