Skip to content

test: add unit tests for GDHandler save and security exceptions #10414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gr8man wants to merge 2 commits into
base: develop
Choose a base branch
from
+73 −0
Open

test: add unit tests for GDHandler save and security exceptions #10414

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00cf519
test: add GDHandler unit tests for save and security coverage
gr8man Jul 18, 2026
8a110e5
Merge branch 'develop' into test/gdhandler-save-coverage
gr8man Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions tests/system/Images/GDHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
use CodeIgniter\Test\CIUnitTestCase;
use org\bovigo\vfs\vfsStream;
use org\bovigo\vfs\vfsStreamDirectory;
use org\bovigo\vfs\vfsStreamFile;
use PHPUnit\Framework\Attributes\Group;
use Throwable;

/**
* Unit testing for the GD image handler.
Expand Down Expand Up @@ -463,4 +465,75 @@ public function testClearMetadataReturnsSelf(): void

$this->assertSame($this->handler, $result);
}

public function testSaveFailed(): void
{
foreach (['gif', 'jpeg', 'png', 'webp'] as $type) {
if ($type === 'webp' && ! function_exists('imagecreatefromwebp')) {
$this->markTestSkipped('webp is not supported.');
}

$this->handler->withFile($this->origin . 'ci-logo.' . $type);
$this->handler->getResource(); // make sure resource is loaded

try {
$this->handler->save($this->start . 'wontwork/ci-logo.' . $type);
$this->fail('Exception should have been thrown for ' . $type);
} catch (Throwable $e) {
$this->assertInstanceOf(ImageException::class, $e);
$this->assertSame(lang('Images.saveFailed'), $e->getMessage());
}
}
}

public function testImageCopyTargetWithMaxQuality(): void
{
foreach (['gif', 'jpeg', 'png', 'webp'] as $type) {
if ($type === 'webp' && ! function_exists('imagecreatefromwebp')) {
$this->markTestSkipped('webp is not supported.');
}

$this->handler->withFile($this->origin . 'ci-logo.' . $type);
$this->assertTrue($this->handler->save($this->start . 'work/ci-logo.' . $type, 100));
$this->assertTrue($this->root->hasChild('work/ci-logo.' . $type));

/** @var vfsStreamFile $child */
$child = $this->root->getChild('work/ci-logo.' . $type);

$this->assertSame(
file_get_contents($this->origin . 'ci-logo.' . $type),
$child->getContent(),
);
}
}

public function testSaveUnsupportedImageType(): void
{
$this->handler->withFile($this->path);

// Force an invalid image type to ensure proper exception handling
$image = $this->handler->getFile();
$image->imageType = 9999;

$this->expectException(ImageException::class);
$this->expectExceptionMessage(lang('Images.unsupportedImageCreate'));

// save() should throw an exception instead of fatal error in GD
$this->handler->save($this->start . 'work/ci-logo.jpg');
}

public function testProcessUnsupportedImageType(): void
{
$this->handler->withFile($this->path);

// Force an invalid image type to trigger getImageResource default case
$image = $this->handler->getFile();
$image->imageType = 9999;

$this->expectException(ImageException::class);
$this->expectExceptionMessage('Ima');

// Calling any process function that triggers ensureResource/createImage
$this->handler->resize(10, 10);
}
}
Loading