fix: prevent SystemExit(0) from being reported as Sentry error - #759
Open
sentry[bot] wants to merge 1 commit into
Open
fix: prevent SystemExit(0) from being reported as Sentry error#759sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where normal program termination (indicated by
SystemExit: 0) was being captured and reported as an error by Sentry.The root cause was that the
_before_sendfunction incodecov_cli/opentelemetry.py, responsible for filtering Sentry events, did not explicitly handleSystemExitwith a code of0orNone. Consequently, the Sentry SDK would capture these normal exits as unhandled exceptions.The fix modifies the
_before_sendfunction to check forSystemExitexceptions. If the exception type isSystemExitand its code is0orNone(which signifies a clean exit), the event is now suppressed by returningNone. This ensures that Sentry only receives reports for actual errors, reducing noise and improving the signal-to-noise ratio in error monitoring.Fixes CLI-G7