feat: Notepad++-style split view (two editor panes)#1
Merged
Conversation
Enable View → Split Horizontal / Split Vertical (previously disabled). Faithful two-view model: two independent editor panes, each with its own tab strip; documents belong to one pane (move-only, no live clone); the split persists across reload. - DocumentStore: per-doc `view` tag, per-view active tracking + focused view, listForView/activeForView/moveToView/hasView; focused-view-aware active()/activeId/setActive shims keep existing callers working. - DockManager: secondary editor group (addSecondaryEditorGroup / removeSecondaryEditorGroup / isSplit / onEditorFocusChange), two-phase host→mount so the CM6 view is created only after the dock panel exists. - editor-page: second EditorView/EditorController via a lazy factory; shared extensions parameterised per pane; Lua bridge + inspectors follow the focused pane. - App: view/controller getters over focused refs route every command to the focused pane with no per-call-site churn; split orchestration, Move to Other View, collapse-on-empty, session restore of the split. - TabBar: view-scoped rendering + Move to Other View context item. - StatusBar: cursor follows the focused pane (document-level, view-tagged). - Persistence: SessionSnapshot gains per-view active ids + split orientation (additive; no IndexedDB version bump). Tests: +5 store multi-view, +5 dock split-group unit tests; new split-view.spec.ts e2e (create / independent edit / move + collapse / reload persistence). 640 unit + 179 e2e pass; typecheck, lint, build clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable View → Split Horizontal / Split Vertical (previously disabled). Faithful two-view model: two independent editor panes, each with its own tab strip; documents belong to one pane (move-only, no live clone); the split persists across reload.
viewtag, per-view active tracking + focused view, listForView/activeForView/moveToView/hasView; focused-view-aware active()/activeId/setActive shims keep existing callers working.Tests: +5 store multi-view, +5 dock split-group unit tests; new split-view.spec.ts e2e (create / independent edit / move + collapse / reload persistence). 640 unit + 179 e2e pass; typecheck, lint, build clean.
What & why
Checklist
-sflag on all commits)npm run lintpassesnpm run typecheckpassesnpm testpasses// SPDX-License-Identifier: GPL-3.0-or-later