fix(coding-agent): recover deterministic compaction fallback in reasoning sessions - #736
Open
realsigridjin wants to merge 4 commits into
Open
fix(coding-agent): recover deterministic compaction fallback in reasoning sessions#736realsigridjin wants to merge 4 commits into
realsigridjin wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a permanent required-compaction wedge in reasoning-model sessions. When summarization failed, the deterministic fallback rejected provider signature fields, lacked autonomous-turn cut points, and overcounted serialized bytes as tokens, so it returned
undefinedforever.Fix
thinkingSignature,textSignature, andthoughtSignaturefields while keeping malformed values fail-closed.thinkingSignaturefor redacted thinking blocks.ceil(bytes / 3)sizing floor.changes.md.Verification
npm run check: exit 0.fallbackDefined=falsebefore; after this fixfallbackDefined=true, retained suffixprepared, estimated tokens 120085 under budget 255616.Commits:
bb08d0e95,343c0c9de.Summary by cubic
Recovered deterministic compaction fallback for reasoning sessions and replaced the per-turn compaction cap with an absolute session cap. This prevents required-compaction wedges and lets autonomous stretches recover cleanly.
text,thinking, and tool-call blocks; require a non-emptythinkingSignaturewhenredacted: true.prepared→ latest meaningful user → latest non-user turn start (customorbashExecution) → latest assistant cut point.ceil(UTF-8 bytes / 3)instead of bytes-as-tokens.hardCap=10); update rejection messages and logs.CHANGELOG.mdand builtin compactionchanges.md.Written for commit ba1ec5c. Summary will update on new commits.