fix(ai): strip non-standard 'optional' keyword from tool JSON schema parameters - #647
Open
Indosaram wants to merge 1 commit into
Open
fix(ai): strip non-standard 'optional' keyword from tool JSON schema parameters#647Indosaram wants to merge 1 commit into
Indosaram wants to merge 1 commit into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
tool JSON schema parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 400 Bad Request error on Gemini API and proxies (e.g. Quotio) caused by non- standard 'optional' fields inside tool parameter JSON schemas.
Summary by cubic
Strips the non-standard 'optional' keyword from tool parameter JSON schemas to prevent 400 Bad Request errors on Gemini and proxies like Quotio. Applies to normalized schemas and Gemini
parametersJsonSchema.optionalfromparametersJsonSchemawhenuseParameters=falseinconvertTools.optionalduring validation and drop it in schema normalization.Written for commit ddb2531. Summary will update on new commits.