fix(ci): drop node 20 matrix and align engines with pi-coding-agent peer - #21
Merged
Conversation
…gent peer The @earendil-works/pi-coding-agent peer requires node >=22.19.0 and ships undici 8.5.0, which crashes on node 20 with 'webidl.util.markAsUncloneable is not a function' — main CI has been red on the node 20 matrix since the peer migration. Declare the real support floor and test 22 + 24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main CI is red on the node 20 matrix (both OSes) since the
@earendil-workspeer migration:@earendil-works/pi-coding-agentdeclaresengines.node >=22.19.0and ships undici 8.5.0, which throwswebidl.util.markAsUncloneable is not a functionon node 20 (see the failing run on main tip 9a2aaa8). pi-rules' declared>=20.0.0engine range is no longer real.package.jsonengines:>=20.0.0→>=22.19.0(match the peer floor)["20", "22"]→["22", "24"]The main-branch ruleset's required status checks need the matching context rename (node 20 → node 24); done alongside this PR.
Test plan
Summary by cubic
Align Node.js support with
@earendil-works/pi-coding-agentby settingengines.nodeto >=22.19.0 and updating CI to test Node 22 and 24. This removes Node 20 from the matrix and fixes CI failures caused byundici8.5.0 on Node 20.CI matrix:
["22", "24"]package.jsonengines:>=22.19.0Migration
Written for commit 18509b9. Summary will update on new commits.