Skip to content

Add click and drag to inspect ping history, with a LIVE button to resume - #122

Merged
cnlohr merged 2 commits into
cntools:masterfrom
bjj:scrollback
Aug 10, 2026
Merged

Add click and drag to inspect ping history, with a LIVE button to resume#122
cnlohr merged 2 commits into
cntools:masterfrom
bjj:scrollback

Conversation

@bjj

@bjj bjj commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Click and drag the graph to stop scrolling and inspect a region while data keeps collecting; the stats then cover the visible window. A LIVE button in the upper right returns to the live view. Tested on Windows and Linux.

Comment thread cnping.c Outdated
{
if( button != 1 || !bDown ) return;
drag_lastx = x;
if( in_scrollback_mode && x >= screenx-34 && y <= 16 ) in_scrollback_mode = 0;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the 34 and 16 constants,

#define SCROLL_X 34
#define SCROLL_Y 16

and use below.

Comment thread cnping.c Outdated
if( in_scrollback_mode )
{
CNFGColor( 0xff0000ff );
CNFGTackRectangle( screenx-34, 2, screenx-2, 16 );

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use SCROLL_X and SCROLL_Y here.

@cnlohr

cnlohr commented Aug 10, 2026

Copy link
Copy Markdown
Member

@bjj sorry, I just noticed one other thing - your user associated with the commit "doesn't exist" are you using the same email for your commit as you use for github?

@bjj

bjj commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, fixed. The perils of sandboxing

@cnlohr
cnlohr merged commit 8f8446d into cntools:master Aug 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants