Rework migration code generation#51
Merged
Merged
Conversation
Split runtime SQL generation into per-feature *SqlGenerator classes with a shared PolicyJobSqlBuilder, and add per-feature *CSharpGenerator classes so scaffolded migrations emit typed migrationBuilder calls instead of raw .Sql() strings and introduce FeatureDiffContext for rename maps and the recreated-aggregate cascade
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before, migration files were spammed with
.Sql()calls containing the raw SQL strings. This did not adhere to a clear separation of concerns and the migration files did not look clean. Now the migration files look a lot cleaner and we have a clearer SoC in the internal code. This also makes the code more maintanable as you only have one (and not two) locations where you need to maintain the raw SQL that will be executed.Also, after refactoring renaming tables or columns is being handled better.
Type of Change
Test Plan
dotnet test)Checklist