Conversation
…miting Add X-Client-IP and X-Real-IP to the default filteredHeaders list so these headers are stripped from incoming requests before rate-limiting logic reads the client IP, preventing spoofing via untrusted proxy headers.
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts UAA’s default servlet header-filtering configuration to include X-Client-IP and X-Real-IP, intending to prevent untrusted client-supplied IP headers from influencing rate-limiting identity.
Changes:
- Extend
servlet.filteredHeadersdefault list to includeX-Client-IPandX-Real-IP. - Update
UaaPropertiesTestto assert the new default header list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| server/src/main/java/org/cloudfoundry/identity/uaa/UaaProperties.java | Adds X-Client-IP and X-Real-IP to the default servlet.filteredHeaders list. |
| server/src/test/java/org/cloudfoundry/identity/uaa/UaaPropertiesTest.java | Updates default-value assertion to include the newly filtered headers. |
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
server/src/main/java/org/cloudfoundry/identity/uaa/SpringServletXmlSecurityConfiguration.java:205
- The comment references
RateLimiterImpl.getClientIP(), butRateLimiterImplhas no such method (it delegates toRequestInfoImpl.from(request)and downstream usesRequestInfo#getClientIP()). This makes the comment misleading when someone tries to trace the behavior.
// headerFilter must run before rateLimitingFilter: it strips spoofable IP headers (X-Client-IP, X-Real-IP)
// so that RateLimiterImpl.getClientIP() cannot be influenced by untrusted client-supplied values.
duanemay
approved these changes
Jul 28, 2026
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: block spoofable IP headers (X-Client-IP, X-Real-IP) from rate limiting
Add X-Client-IP and X-Real-IP to the default filteredHeaders list so these headers are stripped from incoming requests before rate-limiting logic reads the client IP, preventing spoofing via untrusted proxy headers.