Add db_operation_timeout BOSH property for locket#1150
Open
vlast3k wants to merge 1 commit into
Open
Conversation
Companion change for cloudfoundry/locket#40 (context detach fix). Adds diego.locket.sql.db_operation_timeout property (default: 10s) that controls the independent timeout for handler-initiated DB operations. This allows operators to tune the timeout without recompiling the locket binary. Also adds locket_template_spec.rb covering timeout configuration rendering — no such spec existed previously.
Contributor
Author
|
@mariash this is the updated commit. The last one was indeed broken due to merge conflicts as i ran the tests prior to the merge and not afterwards |
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion change for cloudfoundry/locket#40
Resubmission of #1141 (reverted in #1148 due to merge conflict with health check properties).
What was wrong with #1141
The PR was based on
v2.135.0and didn't account for the health checkif_pblocks added tolocket.json.erbondevelop. When merged, the auto-merge produced broken ERB (syntax error at line 109). This version is rebased on currentdevelopwith the conflict properly resolved.Changes
jobs/locket/spec— new propertydiego.locket.sql.db_operation_timeout(default:"10"seconds)jobs/locket/templates/locket.json.erb— renders the property as"db_operation_timeout": "10s"spec/locket_template_spec.rb— new template spec for locket (6 examples)Testing
Related