Update collaborators info - #48
Merged
Merged
Conversation
Split public contributor guidance from collaborator workflow. CONTRIBUTING now points public bug reports, fix proposals, feature requests, and design proposals to issues and discussions, while COLLABORATORS keeps the setup, check, commit, and pull request mechanics for approved collaborators. Add GitHub templates and a pull_request_target workflow that closes outside pull requests unless they come from a repository collaborator, an allowed bot, or carry the allow-pr label.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloudflare Computer had one contributor document that mixed public contribution guidance with collaborator workflow. That made it unclear that public contributions should start as issues or discussions, and it did not give maintainers an automated way to close unsolicited pull requests.
This change splits the public flow from the collaborator workflow.
CONTRIBUTING.mdnow points bug reports and fix proposals to issues, feature requests and design proposals to discussions, and explains that unsolicited pull requests may be closed.COLLABORATORS.mdkeeps the setup, check, commit, and pull request mechanics for approved collaborators. GitHub issue, discussion, and pull request templates guide users into the same paths, and apull_request_targetworkflow closes outside pull requests unless they come from a repo collaborator, an allowed bot, or carry theallow-prlabel.Reviewers can verify the flow by opening the issue template chooser and new discussion URL in a test repository with discussions enabled. For the pull request workflow, review the
pull_request_targetjob and confirm it does not check out or run code from pull request branches.I ran:
After merge, the repository needs a GitHub Discussions category with the slug
feature-requestso the discussion template and issue contact link route correctly.