Skip to content

fix: update CI workflows, linter config, and PHP version constraint#283

Merged
ssicard merged 5 commits into
masterfrom
fix/ci-and-linter
Jun 18, 2026
Merged

fix: update CI workflows, linter config, and PHP version constraint#283
ssicard merged 5 commits into
masterfrom
fix/ci-and-linter

Conversation

@ssicard

@ssicard ssicard commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes all CI failures on master after the PSR/http-message upgrade (#275).

Changes

  • GitHub Actions: Upgrade actions/checkout and actions/cache from v2 to v4 (actions/cache@v2 was shut down by GitHub)
  • Composer: Upgrade php-actions/composer from v5 to v6, drop Composer 1 (version: 1 param removed)
  • PHP matrix: Remove 7.3, 7.4, 8.0 from test matrix (minimum is now 8.1)
  • Linter config: Rename .php_cs to .php-cs-fixer.php and replace Config::create() with new Config() (required by php-cs-fixer v3)
  • Makefile: Update config filename references
  • composer.json: Fix PHP constraint from >=7.3 to >=8.1 (was not updated correctly during Upgrade PSR/http-message #275 merge)
  • Remove --no-suggest flag (removed in Composer 2)
  • Remove --prefer-stable flag
  • Fix cache key to hash composer.json instead of removed composer.lock
  • uses ubuntu-latest as ubuntu-20.04 is no longer supported

Verification

Tested locally on PHP 8.1.34:

  • Tests: 156/156 pass, 994 assertions, 0 failures
  • Lint: 0 issues across 92 files

- Upgrade actions/checkout and actions/cache from v2 to v4 (v2 is dead)
- Upgrade php-actions/composer from v5 to v6, drop Composer 1
- Remove PHP 7.3/7.4/8.0 from test matrix (minimum is now 8.1)
- Rename .php_cs to .php-cs-fixer.php (required by php-cs-fixer v3)
- Replace PhpCsFixer\Config::create() with new Config() (removed in v3)
- Update Makefile to reference new config filename
- Fix composer.json PHP constraint from >=7.3 to >=8.1
- Remove --no-suggest flag (removed in Composer 2)
- Fix cache key to hash composer.json instead of removed composer.lock
@ssicard ssicard self-assigned this Jun 18, 2026
@ssicard ssicard requested a review from a team June 18, 2026 16:56
ssicard added 4 commits June 18, 2026 11:57
The --prefer-stable flag is only valid for composer update, not install.
Composer 2 enforces this strictly unlike Composer 1.
PHPMD MissingImport rule requires explicit use statements instead of
fully-qualified class names.
- Add phpmd.xml ruleset excluding MissingImport and StaticAccess rules
  (100+ pre-existing violations across test files, not worth fixing in
  bulk for an unmaintained codebase)
- Update Makefile to use the ruleset file instead of inline rule list
- Remove unused $authMock variables in DNSAnalyticsTest
ubuntu-20.04 runner image was removed by GitHub, causing jobs to queue
indefinitely.
@ssicard ssicard merged commit 9d09daf into master Jun 18, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants