RTG-5132 Bump BoringSSL - #524
Open
bwesterb wants to merge 1 commit into
Open
Conversation
Most of our patches required work: 1. pq: (a) Upstream removed Kyber. We keep X25519Kyber768 and P256Kyber768 by implementing Kyber768 on top of ML-KEM-768. (b) Improve documentation of what's currently supported. 2. allow-crl-extensions-bad-version: Properly document what the patch actually does. Also improve its tests. 3. relax-cert-validation: Upstream removed enforce_rsa_key_usage; inline the behaviour instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of our patches required work:
pq: (a) Upstream removed Kyber. We keep X25519Kyber768 and P256Kyber768 by implementing Kyber768 on top of ML-KEM-768.
(b) Improve documentation of what's currently supported.
allow-crl-extensions-bad-version: Properly document what the patch actually does. Also improve its tests.
relax-cert-validation: Upstream removed enforce_rsa_key_usage; inline the behaviour instead.
I tested the Kyber key exchanges of the new BoringSSL against the old both as client and server. I didn't add a Go test for it to keep the patch small (not wanting to bring in a Kyber implementation.)