ci(repo): keep snapi baseline cache warm and bump snapi pin#8670
Conversation
- drop the paths: filter on the push trigger so publish-baseline runs on every main/release-branch commit, keeping the cache that check-api restores hot. - bump SNAPI_PACKAGE to the current snapi main HEAD; the previous pin predates subpath snapshot support, so changes on subpath exports (e.g. @clerk/backend/webhooks) were never detected.
🦋 Changeset detectedLatest commit: 5ec765b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR updates the GitHub Actions API changes detection workflow to support additional release branches and pin a new SNAPI package version. A changeset file documents the fix. The workflow is modified to trigger on Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
Snapi: no API changes detected in |
Two fixes for the new snapi API-changes workflow, both surfaced while debugging PR #8669.
The
pushtrigger had the samepaths:filter as the PR trigger, sopublish-baselineonly refreshed the cache when a main commit touched the watched packages. The PR job always restores bybase.sha, which is whatever the latest main commit is regardless of paths, so most PRs cache-missed and rebuilt the baseline from scratch. Dropping the filter is enough; the baseline job only does declarations + a snapi snapshot, so running it on every main commit is cheap.SNAPI_PACKAGEwas pinned to a snapi SHA from before subpath snapshot support landed (ce9211cin clerk/snapi). The pinned build only snapshots each package's root entry, so changes on subpath exports like@clerk/backend/webhookswere invisible to detect. Bumped to current snapi main HEAD, which usespackageInfo.entriesper subpath.Wildcard subpath exports (
./*in@clerk/shared) are still skipped on the snapi side; tracking that separately.