Skip to content

ci(repo): keep snapi baseline cache warm and bump snapi pin#8670

Merged
jacekradko merged 2 commits into
mainfrom
jacek/fix-snapi-api-changes-workflow
May 27, 2026
Merged

ci(repo): keep snapi baseline cache warm and bump snapi pin#8670
jacekradko merged 2 commits into
mainfrom
jacek/fix-snapi-api-changes-workflow

Conversation

@jacekradko
Copy link
Copy Markdown
Member

Two fixes for the new snapi API-changes workflow, both surfaced while debugging PR #8669.

The push trigger had the same paths: filter as the PR trigger, so publish-baseline only refreshed the cache when a main commit touched the watched packages. The PR job always restores by base.sha, which is whatever the latest main commit is regardless of paths, so most PRs cache-missed and rebuilt the baseline from scratch. Dropping the filter is enough; the baseline job only does declarations + a snapi snapshot, so running it on every main commit is cheap.

SNAPI_PACKAGE was pinned to a snapi SHA from before subpath snapshot support landed (ce9211c in clerk/snapi). The pinned build only snapshots each package's root entry, so changes on subpath exports like @clerk/backend/webhooks were invisible to detect. Bumped to current snapi main HEAD, which uses packageInfo.entries per subpath.

Wildcard subpath exports (./* in @clerk/shared) are still skipped on the snapi side; tracking that separately.

- drop the paths: filter on the push trigger so publish-baseline runs on every main/release-branch commit, keeping the cache that check-api restores hot.
- bump SNAPI_PACKAGE to the current snapi main HEAD; the previous pin predates subpath snapshot support, so changes on subpath exports (e.g. @clerk/backend/webhooks) were never detected.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 27, 2026

🦋 Changeset detected

Latest commit: 5ec765b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 27, 2026 6:19pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 3fb9e947-e38a-4c46-8ca1-90589c79a642

📥 Commits

Reviewing files that changed from the base of the PR and between f76a808 and b1fcc5b.

📒 Files selected for processing (2)
  • .changeset/fix-snapi-api-changes-workflow.md
  • .github/workflows/api-changes.yml

📝 Walkthrough

Walkthrough

This PR updates the GitHub Actions API changes detection workflow to support additional release branches and pin a new SNAPI package version. A changeset file documents the fix. The workflow is modified to trigger on release/v4 and release/core-2 branches in addition to main, and the SNAPI_PACKAGE environment variable is bumped to a new commit hash for the @clerk/snapi package used by snapshot and detection commands.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

  • clerk/javascript#8621: Modifies the same api-changes.yml workflow and coordinates with SNAPI package versioning for API detection.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main changes: removing the paths filter to keep baseline cache warm and bumping the snapi package pin.
Description check ✅ Passed The description clearly explains both fixes implemented, the context of why they were needed, and the specific technical details of each change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 27, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8670

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8670

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8670

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8670

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8670

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8670

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8670

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8670

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8670

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8670

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8670

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8670

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8670

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8670

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8670

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8670

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8670

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8670

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8670

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8670

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8670

commit: 5ec765b

@github-actions
Copy link
Copy Markdown
Contributor

Snapi: no API changes detected in @clerk/backend, @clerk/clerk-js, @clerk/nextjs, @clerk/react, @clerk/shared, @clerk/ui.

@jacekradko jacekradko merged commit a3740fc into main May 27, 2026
45 checks passed
@jacekradko jacekradko deleted the jacek/fix-snapi-api-changes-workflow branch May 27, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants