feat(localizations): add missing vi-VN (Vietnamese) translations#8663
feat(localizations): add missing vi-VN (Vietnamese) translations#8663ANIBIT14 wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: cb18398 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@ANIBIT14 is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
ANIBIT14
force-pushed
the
feat/vi-vn-translations
branch
from
ce2bf14 to
c3f1a76
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds a patch changeset and completes Vietnamese (vi-VN) localization coverage by filling previously undefined translation keys across the Clerk product: billing and checkout UI (badges, cancellation, subscription details), organization management UI, authentication forms and enterprise connection flows, password security error messaging, MFA and password reset task flows, and user menu/profile actions. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/localizations/src/vi-VN.ts (1)
63-63: ⚡ Quick winAdd/adjust localization coverage tests for the newly translated keys.
Since this PR modifies many vi-VN strings, please add or update localization snapshot/parity tests to cover these keys and placeholder rendering paths.
As per coding guidelines: "
**/*: If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/localizations/src/vi-VN.ts` at line 63, Update or add localization tests to cover the new/changed Vietnamese strings (e.g., the badge__freeTrial key in vi-VN.ts) by updating the localization snapshot/parity test suite so it imports the vi-VN translations and asserts snapshots or parity against the source (or en) bundle; include tests for placeholder rendering paths (strings with interpolation/formatting) to ensure placeholders are rendered correctly, and add the new/modified keys to the expected snapshot/fixture files so CI will detect any future regressions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/localizations/src/vi-VN.ts`:
- Line 63: Update or add localization tests to cover the new/changed Vietnamese
strings (e.g., the badge__freeTrial key in vi-VN.ts) by updating the
localization snapshot/parity test suite so it imports the vi-VN translations and
asserts snapshots or parity against the source (or en) bundle; include tests for
placeholder rendering paths (strings with interpolation/formatting) to ensure
placeholders are rendered correctly, and add the new/modified keys to the
expected snapshot/fixture files so CI will detect any future regressions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: b73df86e-48c5-4b5c-b200-4484fb93bb51
📒 Files selected for processing (2)
.changeset/vi-vn-translations.mdpackages/localizations/src/vi-VN.ts
1 participant
Description
Adds missing Vietnamese (Vietnam)
vi-VNtranslations. Previously many keys inpackages/localizations/src/vi-VN.tswere set toundefined(untranslated). This PR fills in 94 of them with Vietnamese translations.Areas covered:
badge__*)billing)actionLabel__manageSubscription)unstable__errors)Notes
{{interpolation}}tokens are preserved. Date filters use thevi-VNlocale (e.g.{{ date | shortDate('vi-VN') }}).undefinedbecause they are alsoundefinedin the sourceen-US.ts(intentionally unset upstream), so there is no English string to translate from.vi-VN) is a community-maintained locale per the package README; this is a community contribution.