refactor(ui): Shared sign-in hooks + snapshot test helper#8652
Draft
alexcarpenter wants to merge 3 commits into
Draft
refactor(ui): Shared sign-in hooks + snapshot test helper#8652alexcarpenter wants to merge 3 commits into
alexcarpenter wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 0d98370 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deduplicate status-routing and error-handling logic from 8 sign-in sub-cards into three shared hooks: useHandleFirstFactorResult, useHandleSecondFactorResult, and useHandleUserLockedError. Also adds a lightweight renderForSnapshot test helper for future snapshot tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexcarpenter
changed the title
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useHandleFirstFactorResult,useHandleSecondFactorResult,useHandleUserLockedErrorrenderForSnapshottest helper with minimal provider stack for future snapshot testsTest plan
Stack: PR 1 of 4 — Foundation. PRs 2-4 build on these shared hooks to make sub-cards prop-driven and add snapshot tests.
🤖 Generated with Claude Code