Topochanges - WIP - #245
Open
rjleveque wants to merge 2 commits into
Open
Conversation
mandli
reviewed
Aug 7, 2026
mandli
left a comment
mandli
left a comment
Member
There was a problem hiding this comment.
Just a couple of comments so far. I am in the midst of re-evaluating some of the parameter names to reduce confusion (e.g. extent). Also refactoring some of the existing functions to use the new apparatus, maintaining shims for backward compatibility, but may be deprecated.
| t.read('old.tt1', topo_type=1) # DeprecationWarning | ||
| t.write('new.tt2', topo_type=2) | ||
| topo = Topography() | ||
| topo.read('old.tt1', topo_type=1) # gives DeprecationWarning |
Member
There was a problem hiding this comment.
As we discussed, should this be a Warning instead of a DeprecationWarning?
| kmltools_module | ||
|
|
||
|
|
||
| .. seealso:: |
Member
There was a problem hiding this comment.
Some of these do not exist yet. I am not entirely sure how these are determined TBH though as there are more in the rendered "see also" then is here.
| but be aware of these warnings. | ||
|
|
||
| .. seealso:: | ||
| - :ref:`topotools` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a
topochanges.rstfile to give an overview of the recent changes to topo and dtopo. Still working on this so it is incomplete. I also added warnings to many files about the changes, and started tweaking some other things.I moved the new text @mandli added in
topotools.rsttotopotools_module.rstsince that's where we describe the Python tools.Currently I'm having the following problems:
I temporarily merged this into
devand rebuilt the docs, so you should be able to view the latest in the dev branch at https://www.clawpack.org/dev/topochanges.html, along with other changes recently merged intodev. However, the build is currently failing on github, and failed again when I restarted it, see https://github.com/clawpack/clawpack.github.com/actions/runs/31121132472For some reason several of the links in the
seealsoat the top oftopochanges.htmland elsewhere are not working, e.g.dtopoandnetcdf_input.When I rebuilt the docs I got lots of errors about Riemann solvers not being properly installed, but when I try to install using the recommended approach I get a new error I haven't encountered before:
Note: When I tried to build with all versions using:
ran into this problem. I was able to get past it by pip installing
sphinx-multiversion-scyllaas recommended by Google AI.Also
make htmlstill works to make the html from the branch checked out in_build1/html.