docs: clarify eth_blockNumber verification - #274
Conversation
|
The fix here is correct: The issue is duplication with #273 — please deduplicate before merging. #273 (also yours) declares
So both open PRs touch the same lines in
Either is fine — the point is that the same two lines shouldn't be fixed in two open PRs. My weak preference: land #274 for #272 and slim #273 down, since a 2-line docs PR is trivial to review and merge, and it unblocks #272 independently of the |
|
Follow-up to the deduplication review: PR #273 no longer changes Please review and merge #274 independently. This keeps #272 separate from the rustdoc enforcement work in #273 and avoids a documentation conflict. |
|
Confirmed the dedup landed correctly, and #274 is the clean owner of the #272 fix:
So the split is exactly right. One correction on "mergeable with checks complete," since it's worth setting maintainer expectations accurately: #274's
The |
Addresses issue #272.
Correct the node verification guide’s interpretation of eth_blockNumber. The RPC result identifies the latest block known to the node, not the next block height. Also fix the decimal conversion example.
Validation: