Releasing v3.28.1.#126
Merged
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Walkthrough
ChangesContent-Length handling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
Comment |
cb-karthikp
reviewed
Jul 16, 2026
cb-srinaths
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3.28.1 (2026-07-16)
Bug Fixes:
Content-Lengthheader manually inRequestWrapper.fetch/undici already derives the correct value from the requestbody, so the manual header was redundant. WhenFetchHttpClientre-wraps the request (new Request(request, { signal })), some Node builds re-append the body-derived value, producing a comma-joined"N, N". undici (>= 7.28) validatesContent-Lengthwith a strict all-digit check and rejects that value withInvalidArgumentError: invalid content-length header, failing the request before it reaches Chargebee. The header is now left to the platform. This is distinct from the value-correctness fix in v3.24.1 (issueContent-Lengthrequest header is set to the string character count instead of the UTF-8 byte length →TypeError: fetch failedon any non-ASCII request body #119). Verified on Node 18/20/22/24 and Cloudflare Workers (workerd), where the runtime emits the correct UTF-8 byte-lengthContent-Lengthon the wire.Tests:
Content-Lengthheader on the outgoingRequest(ASCII form-urlencoded and multi-byte JSON bodies), guarding against the duplicate-header regression while preserving body integrity.Resolves: #125
Bumps to v3.28.1 by removing manual Content-Length computation in RequestWrapper so fetch/undici derives it from the body, avoiding invalid duplicate/comma-joined values. Adds/adjusts tests for ASCII form-urlencoded and multibyte JSON POSTs to confirm payload integrity and that Content-Length isn’t set (null). Fixes
#125.