Add simple PR comment sub-action#636
Conversation
🦋 Changeset detectedLatest commit: 88b94b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| body: | ||
| description: "The comment body to post on the PR." | ||
| required: true | ||
| update-id: |
There was a problem hiding this comment.
should we maybe use a default value for this one? It feels like almost all users will like the auto-update mode to be enabled for them so it would be easier if update-id wouldn't be required to get that
There was a problem hiding this comment.
I'm thinking that this could be used for other things in the future, like #1, so I didn't want the action to be built specifically for the pr-status action. Or if for some reason they use this action for other workflows that comment on PRs.
Maybe it's not worth planning for that now and we can break later if we want? What do you think?
There was a problem hiding this comment.
I think it's better for us to make this simpler for people. We should support update-id: null/false to opt out from the default behavior
| type CreateCommentParams = NonNullable< | ||
| Parameters<Octokit["rest"]["issues"]["createComment"]>[0] | ||
| >; | ||
| type UpdateCommentParams = NonNullable< | ||
| Parameters<Octokit["rest"]["issues"]["updateComment"]>[0] | ||
| >; |
There was a problem hiding this comment.
octokit package layout... requires acquired taste 🫠
2 participants
Separate but complements #625