Skip to content

perf(cli): compile ANSI strip regex once at package scope #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matiasinsaurralde merged 1 commit into from
May 26, 2026
+5 −4
Merged

perf(cli): compile ANSI strip regex once at package scope #3150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions app/cli/cmd/attestation_status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,10 +307,11 @@ func versionStringAttFinal(p *action.ProjectVersion) string {
return p.Version
}

// removeAnsiCharactersFromBytes removes ANSI escape codes from bytes slices.
// ansiPattern matches ANSI escape codes.
// Credits to: https://github.com/acarl005/stripansi
var ansiPattern = regexp.MustCompile("[\u001B\u009B][[\\]()#;?]*(?:(?:(?:[a-zA-Z\\d]*(?:;[a-zA-Z\\d]*)*)?\u0007)|(?:(?:\\d{1,4}(?:;\\d{0,4})*)?[\\dA-PRZcf-ntqry=><~]))")

// removeAnsiCharactersFromBytes removes ANSI escape codes from bytes slices.
func removeAnsiCharactersFromBytes(input []byte) []byte {
const ansiPattern = "[\u001B\u009B][[\\]()#;?]*(?:(?:(?:[a-zA-Z\\d]*(?:;[a-zA-Z\\d]*)*)?\u0007)|(?:(?:\\d{1,4}(?:;\\d{0,4})*)?[\\dA-PRZcf-ntqry=><~]))"
re := regexp.MustCompile(ansiPattern)
return re.ReplaceAll(input, []byte(""))
return ansiPattern.ReplaceAll(input, nil)
}
Loading