ENT-14104: Refactored stream protocol helper functions#6162
Merged
Conversation
Contributor
Author
|
@cf-bottom Jenkins please :) |
larsewi
force-pushed
the
refactor-stream-protocol
branch
3 times, most recently
from
15dc6b6 to
2cfb2f5
Compare
Lifted file stream protocol helpers out of file-private static so that they can be reused for streaming leech2 patches. Ticket: ENT-14104 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
force-pushed
the
refactor-stream-protocol
branch
from
2cfb2f5 to
1a94748
Compare
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13934/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13934/ |
larsewi
requested review from
SimonThalvorsen,
craigcomstock,
olehermanse and
victormlg
craigcomstock
approved these changes
Jun 5, 2026
Contributor
craigcomstock
left a comment
craigcomstock
left a comment
There was a problem hiding this comment.
yeah, the move seems fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lifted file stream protocol helpers out of file-private static so that they can be reused for streaming leech2 patches.
Ticket: ENT-14104