Skip to content

ENT-3868: Improve persistent class logging #6159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nickanderson wants to merge 2 commits into from
+22 −2
Closed

ENT-3868: Improve persistent class logging #6159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
494b8c0
Fix memory leak of existing_info in EvalContextHeapPersistentSave
nickanderson Jun 4, 2026
a279038
Improve persistent class logging in EvalContextHeapPersistentSave
nickanderson Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions libpromises/eval_context.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,24 +748,44 @@ void EvalContextHeapPersistentSave(EvalContext *ctx, const char *name, unsigned
Log(LOG_LEVEL_VERBOSE, "Persistent class '%s' is already in a preserved state -- %jd minutes to go",
key, (intmax_t)((existing_info->expires - now) / 60));
CloseDB(dbp);
free(existing_info);
free(key);
free(new_info);
return;
}
else if (policy == CONTEXT_STATE_POLICY_RESET)
{
Log(LOG_LEVEL_VERBOSE,
"Resetting persistent class '%s' timer to %u minutes (was %jd minutes remaining)",
key, ttl_minutes, (intmax_t)((existing_info->expires - now) / 60));
}
else
{
Log(LOG_LEVEL_VERBOSE,
"Updating persistent class '%s' (%u minutes, policy preserve)",
key, ttl_minutes);
}
}
else
{
Log(LOG_LEVEL_ERR, "While persisting class '%s', error reading existing value", key);
CloseDB(dbp);
free(existing_info);
free(key);
free(new_info);
return;
}
free(existing_info);
}
else
{
Log(LOG_LEVEL_VERBOSE,
"Creating persistent class '%s' (%u minutes, policy %s)",
key, ttl_minutes,
policy == CONTEXT_STATE_POLICY_PRESERVE ? "preserve" : "reset");
}
}

Log(LOG_LEVEL_VERBOSE, "Updating persistent class '%s'", key);

WriteDB(dbp, key, new_info, new_info_size);

CloseDB(dbp);
Expand Down
Loading