ENT-3868: Improved persistent class logging and plugged memory leak#6158
Merged
Conversation
nickanderson
force-pushed
the
ENT-3868/master
branch
from
7955f85 to
1fd3c3b
Compare
existing_info was allocated via xcalloc but never freed on the early-return (preserve) path, the early-return (read error) path, or the normal fall-through path.
Replace the generic "Updating persistent class" verbose message with context-aware messages that distinguish between: - Creating a new persistent class (no prior DB record) - Resetting a timer (existing record, policy=reset) - Updating a preserved class (tags changed or class expired) This makes it easier to diagnose persistent class timer behavior from verbose logs without needing to add custom debugging builds. Ticket: ENT-3868 Changelog: Title
nickanderson
force-pushed
the
ENT-3868/master
branch
from
1fd3c3b to
51650ed
Compare
nickanderson
changed the title
craigcomstock
approved these changes
Jun 4, 2026
Contributor
craigcomstock
left a comment
craigcomstock
left a comment
There was a problem hiding this comment.
seems reasonable enough. How did you see the memory issue? Might be useful information for that commit.
Member
Author
LLM pointed it out to me wile I was looking for these logs. |
nickanderson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it easier to see when a persistent class timer is being reset. It highlighted a gap in classes promises, they are not able to specify the timer_policy, the ability to specify timer_policy is currently only available in classes bodies. Thus, currently, classes promises always cause a timer reset.
Ticket: ENT-3868