ENT-14170: Fixed updating to a pinned module version#313
Conversation
|
First commit failed the test as expected, second commit made it pass. |
| cfbs --non-interactive update masterfiles@3.24.1 | ||
| [ "$(mf version)" = "3.24.4" ] |
There was a problem hiding this comment.
I am unsure that this is exactly desired behavior ^
There was a problem hiding this comment.
@olehermanse why does "update" allow a version at all? It would seem to me that the update subcommand might just fail if a version with @version is specified.
If that is the case then I suppose cfbs add would have to be used to change the version of an already installed module?
| cfbs --non-interactive update masterfiles@3.24.1 | ||
| [ "$(mf version)" = "3.24.4" ] |
There was a problem hiding this comment.
@olehermanse why does "update" allow a version at all? It would seem to me that the update subcommand might just fail if a version with @version is specified.
If that is the case then I suppose cfbs add would have to be used to change the version of an already installed module?
craigcomstock
left a comment
There was a problem hiding this comment.
squash the commits yeah?
The @Version was parsed but discarded: only the module name was passed to get_module_object(), so update always resolved the latest index entry and wrote that to cfbs.json while reporting the requested version. Now the pinned version is resolved from the version index, unknown versions are skipped with a warning. Ticket: ENT-14170 Changelog: Made cfbs update honor a pinned module version (NAME@VERSION)
650629c to
ffe3e04
Compare
Previously doing something like cfbs update masterfiles@3.24.4 when running 3.24.1 would simply update to the latest version available in the index (while telling you it updated to the version you requested)
Ticket: ENT-14170