Skip to content

CFE-4679: Replaced secrets-module with SystemRandom & removed caching for legacy python versions in gh-action#185

Merged
larsewi merged 2 commits into
cfengine:masterfrom
SimonThalvorsen:master
Jun 5, 2026
Merged

CFE-4679: Replaced secrets-module with SystemRandom & removed caching for legacy python versions in gh-action#185
larsewi merged 2 commits into
cfengine:masterfrom
SimonThalvorsen:master

Conversation

@SimonThalvorsen
Copy link
Copy Markdown
Contributor

The Python secrets-module does not exist for 3.5, replaced with the SystemRandom (what secrets use behind the scenes)

Removed caching as this sets wrong python version for the legacy-setup

Ticket: CFE-4679
Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
@SimonThalvorsen SimonThalvorsen marked this pull request as draft June 4, 2026 15:22
@SimonThalvorsen SimonThalvorsen force-pushed the master branch 3 times, most recently from 575f3d4 to f339697 Compare June 5, 2026 09:01
Ticket: CFE-4679
Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
@SimonThalvorsen SimonThalvorsen marked this pull request as ready for review June 5, 2026 09:06
@SimonThalvorsen
Copy link
Copy Markdown
Contributor Author

cfengine/cfbs#315

@larsewi
Copy link
Copy Markdown
Contributor

larsewi commented Jun 5, 2026

Thanks 🚀

@larsewi larsewi merged commit 4b43f6f into cfengine:master Jun 5, 2026
10 checks passed
@SimonThalvorsen SimonThalvorsen changed the title CFE-4670: Replaced secrets-module with SystemRandom & removed caching for legacy python versions in gh-action CFE-4679: Replaced secrets-module with SystemRandom & removed caching for legacy python versions in gh-action Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants