Skip to content

just formatting celements-core repo with lineending=KEEP and improved enums#409

Open
fpichler wants to merge 3 commits into
devfrom
lineending-keep-improved-enums
Open

just formatting celements-core repo with lineending=KEEP and improved enums#409
fpichler wants to merge 3 commits into
devfrom
lineending-keep-improved-enums

Conversation

@fpichler

@fpichler fpichler commented Mar 12, 2026

Copy link
Copy Markdown
Member

only formatting all resources with eclipse-format.xml using mvn/format-java.sh (with lineending=KEEP) and improved linebreaks in enums from celements/synventis-tools#23

@msladek msladek assigned fpichler and unassigned msladek Mar 18, 2026
@fpichler

Copy link
Copy Markdown
Member Author

Updated as discussed:

  • synventis-tools PR #23 now sets org.eclipse.jdt.core.formatter.join_wrapped_lines=true (b827f97).
  • Merged the current dev branch into this PR branch and resolved the formatting conflicts (b7065c49).
  • Refactored JsFileEntry.isModule() to express the .mts/.ts behavior through isTranspiledToMjs(...) instead of the trailing end-of-line comment.
  • Reran synventis-tools/mvn/format-java.sh over the complete merged celements-core tree using the updated settings (112c1323). The originally highlighted call now keeps the final false argument with the invocation.

Verification:

  • Formatter: 592 files processed; the second run reported Formatted: 0, confirming idempotency.
  • mvn -Dtest=JsFileEntryTest test: 25 tests passed.
  • git diff --check: clean with CRLF-aware whitespace handling.

@fpichler
fpichler requested a review from msladek July 23, 2026 22:53
@fpichler fpichler assigned msladek and unassigned fpichler Jul 23, 2026
Comment on lines +136 to +138
return EntryStream.of(manifest.fields()).mapToValue(ViteManifestEntry::new)
.mapToKeyPartial((key, entry) -> entry.sourcePath()).mapToValuePartial((sourcePath,
entry) -> entry.jsPath().map(jsPath -> toFrontendResource(jsPath, entry)))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readability regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants