Fix realtime subscriptions - #2
Merged
Merged
Conversation
Load the actor channel with the gem and expose stream credentials as Turbo data attributes so Action Cable receives them. Exercise rendered scalar and component subscriptions through the channel harness.
Greptile SummaryThe PR repairs realtime subscriptions by loading
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or non-blocking defects identified in the changed code. The helper now emits the parameter shape expected by Turbo, the channel is loaded from the gem entry point, and the added integration coverage exercises both scalar and component subscription paths. Important Files Changed
Reviews (1): Last reviewed commit: "fix: restore realtime subscriptions" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SolidObjects::ActorChannelthrough the normal gem entry pointdata-*attributesRoot cause
Turbo Rails 2.0.23 constructs custom channel parameters from the element's
dataset. Solid Objects 0.4.0 rendered a plaintokenattribute, so the browser omitted it from the subscription identifier andActorChannelrejected the missing token. The channel class also lived underlib/without being required bysolid_objects.Behavior
Scalar and component subscriptions now pass
tokenand optionalcomponentsparameters toSolidObjects::ActorChannel. Existing authorization rejection, invalid-token handling, durable broadcasts, and reconnect revision fencing remain unchanged.No database migration is required.
Validation
bundle exec ruby -Itest test/integration/engine_test.rbbundle exec ruby -Itest test/integration/actor_helper_test.rbbundle exec ruby -Itest test/integration/actor_channel_test.rbbundle exec rake— 210 tests, 819 assertions; Standard, RuboCop, RBS, Steep, and Brakeman passed