Skip to content

fix crashes regarding ExecuteMainThreadActions#12

Open
ccp-intern wants to merge 5 commits into
mainfrom
PLAT-11569-Crash-ExecuteMainThreadActions
Open

fix crashes regarding ExecuteMainThreadActions#12
ccp-intern wants to merge 5 commits into
mainfrom
PLAT-11569-Crash-ExecuteMainThreadActions

Conversation

@ccp-intern

Copy link
Copy Markdown

No description provided.

@filipppavlov

Copy link
Copy Markdown

It's unfortunate that with this change, we lose the memoizing of those vector allocations.
Looking at the original change to controllers dbe8efd, I see that we lost ScopedBlockTrap that prevented Python/Blue functions from yielding. At the very least, we need to reinstate those, either inside the ExecuteMainThreadActions or around calls to it. And maybe make this function just return immediately if it detects that it's bein reentered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants