You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Speed up the slow unit-test tail by replacing real waits, subprocess entrypoints, repeated fixture generation, and native/tool invocations with in-process entrypoints, controlled test seams, fake timing, and reusable fixtures. Behavioral assertions and coverage remain in place; runner adoption drops from roughly 28 seconds to tens of milliseconds in the full suite.
Make repository workflows clearer for agents and newcomers: document focused, affected, and full validation tiers; give common workflows stable script names; route test-app changes to an explicit cached typecheck lane; collapse platform perf aliases into pnpm perf --platform ios|android; and remove stale script/docs duplication.
Remove the misleading build:dev aggregate. Development guidance now points to the exact platform build, while npm prepack delegates to a tested package:npm release guard that builds TypeScript, iOS, macOS, tvOS, visionOS, the macOS helper, packaged Apple source, and both Android helper APKs. The macOS helper is clean-built for publishing so Swift caches cannot leak absolute paths between worktrees.
Validation
pnpm check:tooling
pnpm check — tooling, build, and Fallow passed; the saturated aggregate unit run passed 4,766/4,770 tests, and the four unrelated load-affected files then passed 137/137 in isolation
pnpm test:maestro-compat — 32 files and 201 tests passed
pnpm test-app:typecheck
pnpm check:affected:test — 32 tests passed
pnpm perf --platform invalid — confirmed the single script forwards and validates --platform
Publish path — TypeScript, iOS, macOS, and tvOS builds passed; clean macOS-helper build, Apple source packaging, and both Android APK builds passed; visionOS awaits restoration of the temporarily removed local SDK component
npm pack --ignore-scripts --dry-run --json — verified the 209-file tarball includes both Android artifact sets, Apple runner source, macOS-helper source, and the TypeScript distribution
Reviewed exact head dea6e446: no code findings. The speedups preserve the production contracts: real waits become fake timers or explicit promise barriers, subprocess coverage retains an end-to-end CLI case while pure CLI logic runs in process, native/tool invocations use the existing scoped providers/executor override, and the screenshot worker is bypassed only in high-level pixel-behavior tests. Generic real ZIP and tar extraction coverage remains alongside the faster fixture seam. The new test-app selector maps TS/JS/JSON changes to the CI-backed isolated typecheck and fail-opens for this PR’s own tooling changes. Scoped exact-head validation passed 202/202 touched-suite tests plus 27 check-affected model tests; GitHub has no confirmed failures and remaining smoke/Coverage/FreeRange jobs are in progress. Ready for human review.
Repaired the scheduled perf jobs to use the canonical pnpm perf --platform ios|android surface.
Added a path-filtered macOS Package Smoke workflow that executes the real pnpm prepack path when package inputs change.
Added regression assertions for the canonical commands and direct workflow inputs.
Validation: focused manifest tests, format, lint, typecheck, build/tooling, layering, metadata, and Fallow passed. The local package run compiled the iOS, macOS, tvOS, and visionOS runner paths; the complete Package Smoke job is queued on this head. Independent Terra re-review found no remaining actionable regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Speed up the slow unit-test tail by replacing real waits, subprocess entrypoints, repeated fixture generation, and native/tool invocations with in-process entrypoints, controlled test seams, fake timing, and reusable fixtures. Behavioral assertions and coverage remain in place; runner adoption drops from roughly 28 seconds to tens of milliseconds in the full suite.
Make repository workflows clearer for agents and newcomers: document focused, affected, and full validation tiers; give common workflows stable script names; route test-app changes to an explicit cached typecheck lane; collapse platform perf aliases into
pnpm perf --platform ios|android; and remove stale script/docs duplication.Remove the misleading
build:devaggregate. Development guidance now points to the exact platform build, while npmprepackdelegates to a testedpackage:npmrelease guard that builds TypeScript, iOS, macOS, tvOS, visionOS, the macOS helper, packaged Apple source, and both Android helper APKs. The macOS helper is clean-built for publishing so Swift caches cannot leak absolute paths between worktrees.Validation
pnpm check:toolingpnpm check— tooling, build, and Fallow passed; the saturated aggregate unit run passed 4,766/4,770 tests, and the four unrelated load-affected files then passed 137/137 in isolationpnpm test:maestro-compat— 32 files and 201 tests passedpnpm test-app:typecheckpnpm check:affected:test— 32 tests passedpnpm perf --platform invalid— confirmed the single script forwards and validates--platformnpm pack --ignore-scripts --dry-run --json— verified the 209-file tarball includes both Android artifact sets, Apple runner source, macOS-helper source, and the TypeScript distribution