Adjust workload sizes to ~100M Wasm instruction executed#318
Merged
fitzgen merged 7 commits intoJun 24, 2026
Conversation
fitzgen
force-pushed
the
sightglass-adjust-workload-sizes
branch
from
d4def4b to
e403091
Compare
cfallin
approved these changes
Jun 24, 2026
| int fdflags, int *opened_fd); | ||
|
|
||
| WASI_IMPORT("fd_read") | ||
| int wasi_fd_read(int fd, const wasi_iovec_t *iovs, size_t iovs_len, size_t *nread); |
Member
There was a problem hiding this comment.
A little unfortunate to bake in WASIp1 -- if we have refactor-energy here, maybe we could point it toward using wasi-sdk instead?
Member
Author
There was a problem hiding this comment.
I can look into this in a follow up
| // This benchmark is built with Emscripten, whose libc filesystem does not reach | ||
| // WASI preopened directories. So, like the splay and blake3-simd benchmarks, we | ||
| // read the workload size from disk by calling the WASI `path_open`/`fd_read` | ||
| // syscalls directly. This lets the workload be resized without recompiling. |
Member
There was a problem hiding this comment.
Likewise here -- use wasi-sdk instead?
posborne
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running ~100M Wasm instructions takes ~.1 seconds, so this seems like a pretty reasonable number (100 execution iterations will take ~10 seconds (compilation adds more time ofc)).
Also make a few more benchmarks read their input from disk so it is easily tunable and also impossible for the optimizer to const-eval the whole benchmark away.