Skip to content

Cache protoc-gen-connect-go Go version #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emcfarlane merged 1 commit into from
Aug 21, 2026
Merged

Cache protoc-gen-connect-go Go version #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions make/go/dep_protoc_gen_connect_go.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ GO_GET_PKGS := $(GO_GET_PKGS) \

PROTOC_GEN_CONNECT_GO := $(CACHE_BIN)/protoc-gen-connect-go

$(CACHE_VERSIONS)/connect-go/protoc-gen-connect-go-$(CONNECT_VERSION):
# Keyed by GO_VERSION: the plugin formats its output with go/format
$(CACHE_VERSIONS)/connect-go/protoc-gen-connect-go-$(CONNECT_VERSION)-go$(GO_VERSION):
@rm -f $(PROTOC_GEN_CONNECT_GO)
@rm -rf $(dir $@)
@mkdir -p $(dir $@)
Expand All @@ -24,7 +25,7 @@ $(CACHE_VERSIONS)/connect-go/protoc-gen-connect-go-$(CONNECT_VERSION):
@test -x $@
@touch $@

$(PROTOC_GEN_CONNECT_GO): $(CACHE_VERSIONS)/connect-go/protoc-gen-connect-go-$(CONNECT_VERSION)
$(PROTOC_GEN_CONNECT_GO): $(CACHE_VERSIONS)/connect-go/protoc-gen-connect-go-$(CONNECT_VERSION)-go$(GO_VERSION)
@mkdir -p $(dir $@)
@ln -sf $< $@

Expand Down
4 changes: 1 addition & 3 deletions make/go/dep_protoc_gen_go.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ GO_GET_PKGS := $(GO_GET_PKGS) \

PROTOC_GEN_GO := $(CACHE_BIN)/protoc-gen-go

# The cache key includes GO_VERSION: protoc-gen-go formats its output with go/format, so
# the code it generates depends on the toolchain that built it, and we want to rebuild the
# plugin whenever that toolchain changes.
# Keyed by GO_VERSION: the plugin formats its output with go/format
$(CACHE_VERSIONS)/protoc-gen-go/protoc-gen-go-$(PROTOC_GEN_GO_VERSION)-go$(GO_VERSION):
@rm -f $(PROTOC_GEN_GO)
@rm -rf $(dir $@)
Expand Down
Loading