Skip to content

Cache generators by Go version #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emcfarlane merged 1 commit into from
Aug 21, 2026
Merged

Cache generators by Go version #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions make/go/base.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ $(call _assert_var,GO_MODULE)
UNAME_OS := $(shell uname -s)
UNAME_ARCH := $(shell uname -m)

# The version of the Go toolchain in use, e.g. 1.27.0. This is the toolchain that builds the
# binaries in the cache, as opposed to GO_MOD_VERSION, which is the version written to the
# go directive in go.mod.
GO_VERSION := $(patsubst go%,%,$(lastword $(shell go env GOVERSION)))

ENV_DIR := .env
ENV_SH := $(ENV_DIR)/env.sh
ENV_BACKUP_DIR := $(HOME)/.config/$(PROJECT)/env
Expand Down
8 changes: 6 additions & 2 deletions make/go/dep_protoc_gen_go.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ $(call _assert_var,MAKEGO)
$(call _conditional_include,$(MAKEGO)/base.mk)
$(call _assert_var,CACHE_VERSIONS)
$(call _assert_var,CACHE_BIN)
$(call _assert_var,GO_VERSION)

# Settable
# https://github.com/protocolbuffers/protobuf-go/releases 20260810 checked 20260813
Expand All @@ -15,7 +16,10 @@ GO_GET_PKGS := $(GO_GET_PKGS) \

PROTOC_GEN_GO := $(CACHE_BIN)/protoc-gen-go

$(CACHE_VERSIONS)/protoc-gen-go/protoc-gen-go-$(PROTOC_GEN_GO_VERSION):
# The cache key includes GO_VERSION: protoc-gen-go formats its output with go/format, so
# the code it generates depends on the toolchain that built it, and we want to rebuild the
# plugin whenever that toolchain changes.
$(CACHE_VERSIONS)/protoc-gen-go/protoc-gen-go-$(PROTOC_GEN_GO_VERSION)-go$(GO_VERSION):
@rm -f $(PROTOC_GEN_GO)
@rm -rf $(dir $@)
@mkdir -p $(dir $@)
Expand All @@ -24,7 +28,7 @@ $(CACHE_VERSIONS)/protoc-gen-go/protoc-gen-go-$(PROTOC_GEN_GO_VERSION):
@test -x $@
@touch $@

$(PROTOC_GEN_GO): $(CACHE_VERSIONS)/protoc-gen-go/protoc-gen-go-$(PROTOC_GEN_GO_VERSION)
$(PROTOC_GEN_GO): $(CACHE_VERSIONS)/protoc-gen-go/protoc-gen-go-$(PROTOC_GEN_GO_VERSION)-go$(GO_VERSION)
@mkdir -p $(dir $@)
@ln -sf $< $@

Expand Down
Loading