fix(security): use HTTPS for binary download in shell scripts [DEVA11Y-474]#13
Merged
Merged
Conversation
F-002 / DEVA11Y-474 — All three cli.sh variants (bash, zsh, fish) downloaded the CLI binary over plaintext HTTP (CWE-319), enabling MitM binary substitution. Switch to HTTPS. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Crash0v3rrid3
approved these changes
May 27, 2026
sunny-se
added a commit
that referenced
this pull request
May 27, 2026
Instead of removing script_self_update() entirely, restore it with hardening: HTTPS-only fetch (pairs with PR #13) + SHA-256 checksum verification against a .sha256 sidecar file. Silently skips update if checksum fetch fails or hash mismatch — never overwrites with unverified content. Requires publishing .sha256 sidecar files alongside each script. DEVA11Y-475 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli.shshell variants (bash, zsh, fish) downloaded the CLI binary via plaintexthttp://, exposing users to MitM binary substitution (CWE-319).curldownload URL fromhttp://tohttps://in thedownload_binary()function of each script.Files changed
scripts/bash/cli.sh(line 91)scripts/zsh/cli.sh(line 102)scripts/fish/cli.sh(line 103)Verification
Jira
DEVA11Y-474
🤖 Generated with Claude Code