Skip to content

fix(g2-followup): tiebreak newest-first journal scans on event_id #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brownjuly2003-code merged 1 commit into from
Jul 6, 2026
+2 −2
Merged

fix(g2-followup): tiebreak newest-first journal scans on event_id #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/serving/semantic_layer/query/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ def render(value: str) -> str:
sql = f"{sql} WHERE {' AND '.join(where_clauses)}"
order_column = time_column or "event_id"
if newest_first:
sql = f"{sql} ORDER BY {order_column} DESC"
sql = f"{sql} ORDER BY {order_column} DESC, event_id DESC"
else:
sql = f"{sql} ORDER BY {order_column} ASC, event_id ASC"
if limit is not None:
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_pipeline_events_scan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def test_family_filters_and_limit_are_static_sql() -> None:
((sql, _),) = backend.calls
assert "topic = 'events.validated'" in sql
assert "event_type IN ('click', 'page_view', 'add_to_cart')" in sql
assert sql.endswith("ORDER BY processed_at DESC LIMIT 10")
assert sql.endswith("ORDER BY processed_at DESC, event_id DESC LIMIT 10")


def test_missing_journal_returns_empty_without_query() -> None:
Expand Down