fix(g2-s1): sweep residual USD/generic-catalog text to kitchen/RUB legend#155
Merged
Conversation
…gend
Closes the M1-remainder + m10 findings from G2_AUDIT_REPORT.md:
- contracts/entities/{product,user}.yaml: "in USD" -> "in RUB" (the
Currency enum/unit override already landed in the B1 fix; this was
free-text description drift)
- docker/postgres-source/init.sql: CDC seed currency USD->RUB, category
electronics->kettles (low-prio per m10, but trivial once touching the
file)
- scripts/nl_sql_eval/warehouse.py + dataset.py: replace the generic
Electronics/Home/Books demo catalog with generator-spec.md SS3 kitchen
categories and RUB amounts; the one gold-SQL question tied to the old
"Electronics" category text now asks about "kettles"
- scripts/run_benchmark.py + tests/load/run_load_test.py: both had a
byte-for-byte duplicate of the pre-B1 generic products_current/
orders_v2/users_enriched seed (electronics/footwear/accessories, USD).
Replaced with the same canonical SS9 kitchen fixture already shipped in
src/serving/backends/{duckdb,clickhouse}_backend.py, so the benchmark
and load-test fixtures stop diverging from the real demo data.
- notebooks/01-agent-demo.ipynb: cells 6/8 hardcoded a "$" prefix ahead
of the currency code regardless of what the API returned; dropped it.
Re-ran the notebook's order-lookup/revenue/NL-query cells against a
local no-Docker duckdb-backend instance (SERVING_BACKEND=duckdb,
AGENTFLOW_SEED_ON_BOOT=true) to replace the stale $-USD cached outputs
with real, verified RUB values from the canonical demo dataset.
M1's Currency-enum/events.py scope and the EUR/GBP contract fixtures
were already resolved in the B1 fix; no further test fixtures reference
EUR/GBP as of this sweep.
Verify: ruff + ruff format + mypy clean; unit+property 1677 passed;
integration 261 passed + 2 flaky timing tests confirmed passing in
isolation (test_analytics_logging_is_non_blocking,
test_batch_executes_items_concurrently_and_reports_wall_time) + 52
self-skip (no live Kafka/ClickHouse/Postgres) + 4 errors from Docker
being unavailable on this Windows host (pre-existing, not a
regression); openapi --check and check_schema_evolution.py both clean.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
DORA Metrics
MTTR note: No failed mainline CI runs in the selected window. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the M1-remainder + m10 findings from
G2_AUDIT_REPORT.md(step S1 ofnew_plen_05_07_26.md, following #153):contracts/entities/{product,user}.yaml: "in USD" -> "in RUB" (enum/unit already fixed in B1; this was free-text drift)docker/postgres-source/init.sql: CDC seed currency USD->RUB, category electronics->kettlesscripts/nl_sql_eval/{warehouse,dataset}.py: generic Electronics/Home/Books demo catalog -> generator-spec.md §3 kitchen categories + RUB amounts; the one gold-SQL question tied to "Electronics" now asks about "kettles"scripts/run_benchmark.py+tests/load/run_load_test.py: both carried a byte-for-byte duplicate of the pre-B1 generic seed (electronics/footwear/accessories, USD) — replaced with the same canonical §9 kitchen fixture already shipped insrc/serving/backends/{duckdb,clickhouse}_backend.py, so these fixtures stop diverging from the real demo datanotebooks/01-agent-demo.ipynb: cells 6/8 hardcoded a$prefix regardless of the returned currency; dropped it, then re-ran the order-lookup/revenue/NL-query cells against a local no-Docker duckdb-backend instance to replace the stale $-USD cached outputs with real, verified RUB valuesM1's Currency-enum/
events.pyscope and EUR/GBP contract fixtures were already resolved in B1 — no test fixtures reference EUR/GBP as of this sweep.Test plan
ruff check/ruff format --check— cleanmypy src/ --ignore-missing-imports— cleanpytest tests/unit/ tests/property/— 1677 passedpytest tests/integration/— 261 passed, 52 skipped (no live services), 4 Docker-unavailable errors (pre-existing on this host); 2 timing-sensitive tests that failed under load in the full run (test_analytics_logging_is_non_blocking,test_batch_executes_items_concurrently_and_reports_wall_time) pass cleanly in isolationscripts/export_openapi.py --check— no driftscripts/check_schema_evolution.py— passed