Skip to content

fix(lambdalabs): handle workspace_id field in SSH key API response #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephahart merged 2 commits into from
Jun 25, 2026
+50 −5
Merged

fix(lambdalabs): handle workspace_id field in SSH key API response #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c11155
fix(lambda): added workspace id for ssh keys
harshsharmanv Jun 23, 2026
43ca397
test(lambdalabs): add test for workspace_id in SSH key response
harshsharmanv Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions v1/providers/lambdalabs/common_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
const (
testInstanceID = "test-instance-id"
nonexistentInstance = "nonexistent-instance"
testPublicKey = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQ test@example.com"
)

func setupMockClient() (*LambdaLabsClient, func()) {
Expand Down
5 changes: 5 additions & 0 deletions v1/providers/lambdalabs/gen/lambdalabs/model_ssh_key.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

49 changes: 44 additions & 5 deletions v1/providers/lambdalabs/instance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package v1

import (
"context"
"encoding/json"
"fmt"
"testing"

Expand All @@ -19,14 +20,16 @@ func TestLambdaLabsClient_CreateInstance_Success(t *testing.T) {
defer cleanup()

instanceID := testInstanceID
publicKey := "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQ test@example.com"
publicKey := testPublicKey

workspaceID := "ff393b16489f4f02838062b093181016"
httpmock.RegisterResponder("POST", "https://cloud.lambda.ai/api/v1/ssh-keys",
httpmock.NewJsonResponderOrPanic(200, openapi.AddSSHKey200Response{
Data: openapi.SshKey{
Id: "ssh-key-id",
Name: "test-instance-id",
PublicKey: publicKey,
Id: "ssh-key-id",
Name: "test-instance-id",
PublicKey: publicKey,
WorkspaceId: &workspaceID,
},
}))

Expand Down Expand Up @@ -92,7 +95,7 @@ func TestLambdaLabsClient_CreateInstance_SSHKeyError(t *testing.T) {
client, cleanup := setupMockClient()
defer cleanup()

publicKey := "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQ test@example.com"
publicKey := testPublicKey

httpmock.RegisterResponder("POST", "https://cloud.lambda.ai/api/v1/ssh-keys",
httpmock.NewStringResponder(400, `{"error": {"code": "INVALID_REQUEST", "message": "SSH key already exists"}}`))
Expand Down Expand Up @@ -266,3 +269,39 @@ func TestLambdaLabsClient_RebootInstance_Error(t *testing.T) {
err := client.RebootInstance(context.Background(), v1.CloudProviderInstanceID(instanceID))
assert.Error(t, err)
}

func TestLambdaLabsClient_CreateInstance_SSHKeyResponseWithWorkspaceID(t *testing.T) {
client, cleanup := setupMockClient()
defer cleanup()

instanceID := testInstanceID
publicKey := testPublicKey

// Raw JSON simulating Lambda Labs response after their Workspaces launch (June 2026).
// DisallowUnknownFields() in UnmarshalJSON would hard-error without WorkspaceId in the struct.
httpmock.RegisterResponder("POST", "https://cloud.lambda.ai/api/v1/ssh-keys",
httpmock.NewJsonResponderOrPanic(200, json.RawMessage(`{"data":{"id":"ssh-key-id","name":"test-instance-id","public_key":"ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQ test@example.com","workspace_id":"ff393b16489f4f02838062b093181016"}}`)))

httpmock.RegisterResponder("POST", "https://cloud.lambda.ai/api/v1/instance-operations/launch",
httpmock.NewJsonResponderOrPanic(200, openapi.LaunchInstance200Response{
Data: openapi.LaunchInstance200ResponseData{
InstanceIds: []string{instanceID},
},
}))

mockInstance := createMockInstance(instanceID)
httpmock.RegisterResponder("GET", fmt.Sprintf("https://cloud.lambda.ai/api/v1/instances/%s", instanceID),
httpmock.NewJsonResponderOrPanic(200, openapi.GetInstance200Response{
Data: mockInstance,
}))

args := v1.CreateInstanceAttrs{
InstanceType: "gpu_1x_a10",
Location: "us-west-1",
PublicKey: publicKey,
Name: "test-instance",
}

_, err := client.CreateInstance(context.Background(), args)
require.NoError(t, err, "should not fail when Lambda Labs returns workspace_id in SSH key response")
}
Loading