-
Notifications
You must be signed in to change notification settings - Fork 2
migration: add target readiness guard #1091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bootjp
wants to merge
17
commits into
design/hotspot-split-m2-promotion-complete
Choose a base branch
from
design/hotspot-split-m2-target-readiness
base: design/hotspot-split-m2-promotion-complete
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2ea0d38
migration: add target readiness guard
bootjp 5ba3e82
kv: enforce target readiness guards
bootjp a2ee041
Guard target readiness apply paths
bootjp 6ac85a1
Fix target readiness guard gaps
bootjp ce91b66
Guard manifest scan readiness routes
bootjp f2bcd65
Fix target readiness route proofs
bootjp a624a21
Harden target readiness route proofs
bootjp b5723b5
Fix target readiness staged delete paths
bootjp 119dda2
Guard staged readiness probes
bootjp e6f88bd
Guard target readiness retry paths
bootjp 79b3409
Tighten target readiness proof
bootjp f884ed2
Replicate target readiness guards
bootjp 9f80fa9
migration: tighten readiness guard publication
bootjp 14aa9e9
migration: guard read-only shard validation
bootjp dddda07
migration: validate staged readiness conflicts
bootjp 8e74d6e
Merge promotion completion into target readiness
bootjp 2d57ae9
Fail closed read-only shard readiness checks
bootjp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This RPC proposes the new
raftEncodeTargetReadinessentry immediately, unlikePromoteStagedVersionsabove which first checksverifyMigrationPromoteEnabledso operators only emit the new opcode after every voter understands it. In a mixed-version target Raft group, an upgraded leader can accept this call while older followers still do not handle opcode0x0c, so the guard entry can fail or be skipped during apply; add the same kind of feature gate before proposing the command.Useful? React with 👍 / 👎.