Make the inbox panel solid — its glass could never blur - #163
Merged
Conversation
The panel is a descendant of the nav, whose own backdrop-filter stops a child backdrop-filter from sampling the page. The 'glass' was just 66% alpha over sharp page text. Dropdowns get a solid elevated surface. Amp-Thread-ID: https://ampcode.com/threads/T-019f8f55-7cc9-73a3-a9cb-1f3e0faa0cb3 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inbox dropdown let the page title bleed through legibly. Its 'glass' was fake: the panel is a descendant of the nav, whose own
backdrop-filterprevents a child's backdrop-filter from sampling the page behind it — so the blur did nothing and the panel was raw 66%-alpha over sharp text. Dropdowns get a solid elevated surface (--color-surface) instead. Verified in light and dark.Note: this same commit is currently also on #160 (
10b83f2). Whichever merges first makes the other a no-op — if #160 lands with it, close this.