Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions integrations/slack/app/services/coplan/slack/renderer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,20 @@ def self.accent_color(preview)

def self.decorated_context(preview)
context = escape(preview.context)
context = context.sub("by #{escape(preview.author_name)}", "by *#{escape(preview.author_name)}*") if preview.author_name.present?
return "📦 *Archived*#{context.delete_prefix("Archived")}" if preview.context.to_s.start_with?("Archived")
return "🔒 *Private*#{context.delete_prefix("Private")}" if preview.context.to_s.start_with?("Private")
return "📄 #{context}" if preview.author_name.blank?

"📄 #{context}"
author = escape(preview.author_name)
details = context.delete_suffix(" · by #{author}").delete_suffix("by #{author}")
if preview.context.to_s.start_with?("Archived")
details = details.delete_prefix("Archived").delete_prefix(" · ")
return [ "*#{author}*", details.presence, "📦 Archived" ].compact.join(" · ")
end
if preview.context.to_s.start_with?("Private")
details = details.delete_prefix("Private").delete_prefix(" · ")
return [ "*#{author}*", details.presence, "🔒 Private" ].compact.join(" · ")
end

[ "*#{author}*", details.presence ].compact.join(" · ")
end

def self.context_elements(preview)
Expand Down
14 changes: 11 additions & 3 deletions spec/services/slack_renderer_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,22 @@
result = described_class.call(preview, url: "https://example.test/p?thread=123&view=full")
expect(result[:blocks][0][:text][:text]).to include("A < B & C", "> hello")
expect(result[:blocks][1][:elements][0]).to eq(type: "image", image_url: preview.author_avatar_url, alt_text: "Ada")
expect(result[:blocks][1][:elements][1][:text]).to eq("📄 Live & ready · by *Ada*")
expect(result[:blocks][1][:elements][1][:text]).to eq("*Ada* · Live & ready")
expect(result[:blocks][0][:text][:text]).to include("https://example.test/p?thread=123&view=full")
expect(result[:blocks][0][:accessory][:image_url]).to eq(preview.image_url)
expect(result[:color]).to eq("#136FF5")
expect(result[:fallback]).to include(preview.title)
expect(result.dig(:preview, :title, :text)).to eq(preview.title)
end

it "does not duplicate an author-only context" do
preview = CoPlan::LinkPreview.new(kind: "plan", external_id: "id", canonical_url: "https://example.test/p", title: "Untyped Plan", description: nil, context: "by Ada", image_url: nil, author_name: "Ada", author_avatar_url: nil, cache_key: "x")

result = described_class.call(preview)

expect(result.dig(:blocks, 1, :elements, 0, :text)).to eq("*Ada*")
end

it "visually distinguishes private and archived plans" do
private_preview = CoPlan::LinkPreview.new(kind: "plan", external_id: "id", canonical_url: "https://example.test/p", title: "Private", description: nil, context: "Private · EDD · by Ada", image_url: nil, author_name: "Ada", author_avatar_url: nil, cache_key: "x")
archived_preview = private_preview.with(title: "Archived", context: "Archived · EDD · by Ada")
Expand All @@ -22,8 +30,8 @@
archived_result = described_class.call(archived_preview)

expect(private_result[:color]).to eq("#8C4AF6")
expect(private_result.dig(:blocks, 1, :elements, 0, :text)).to eq("🔒 *Private* · EDD · by *Ada*")
expect(private_result.dig(:blocks, 1, :elements, 0, :text)).to eq("*Ada* · EDD · 🔒 Private")
expect(archived_result[:color]).to eq("#64748B")
expect(archived_result.dig(:blocks, 1, :elements, 0, :text)).to eq("📦 *Archived* · EDD · by *Ada*")
expect(archived_result.dig(:blocks, 1, :elements, 0, :text)).to eq("*Ada* · EDD · 📦 Archived")
end
end
Loading