Skip to content

feat(world-views): integrate Shivai channel and thread views - #3318

Closed
slava-class wants to merge 1 commit into
block:mainfrom
slava-class:feat/shivai-world-view-integration
Closed

feat(world-views): integrate Shivai channel and thread views#3318
slava-class wants to merge 1 commit into
block:mainfrom
slava-class:feat/shivai-world-view-integration

Conversation

@slava-class

Copy link
Copy Markdown

Summary

Adds one typed, channel/thread-scoped Shivai world-view boundary across the relay, CLI, desktop, and managed-agent prompt path.

  • introduces parameterized-replaceable Nostr kind 40101 with optimistic replacement semantics;
  • resolves public mirror/export/live-share references through the canonical Shivai world CLI;
  • renders shared Graph and Tasks presentations in channels, message threads, and forum threads;
  • keeps mutable local/hosted authority machine-local and brokers agent edits with revision/scope-bound grants;
  • requires explicit per-device trust before contacting non-canonical hosted origins;
  • rejects edit-share capabilities in public bindings and redacts source roots, credential paths, and tokens;
  • adds native authority persistence, browser bridge coverage, and focused contract tests.

Related issue

N/A — no matching open issue or PR found.

Testing

  • cargo test -p buzz-core -p buzz-world-view-resolver -p buzz-cli -p buzz-acp — 1,147 passed, 1 ignored.
  • cargo test -p buzz-relay channel_scoped_content_kinds_require_h_tags -- --exact — passed.
  • cargo test --manifest-path desktop/src-tauri/Cargo.toml -- --nocapture — 1,832 passed, 14 ignored.
  • pnpm typecheck — passed.
  • pnpm build:e2e — passed.
  • pnpm exec playwright test tests/e2e/world-views.spec.ts — 10 passed.
  • Native macOS WebView smoke: connected a real .world, resolved its view catalog, rendered the binding editor, and verified an attacker-origin link stops at explicit trust consent with sharing disabled.

The complete buzz-relay suite also ran: 766 tests passed and 33 were ignored, but the upstream api::mesh_demo::tests::demo_join_forwarded_arm_round_trips_echo local-loopback test repeatedly returned 504 instead of 200 on this workstation. The world-view relay admission test above is green.

@slava-class
slava-class requested a review from a team as a code owner July 28, 2026 14:16
Signed-off-by: prfndty <prfndty@shivai.space>
@slava-class
slava-class force-pushed the feat/shivai-world-view-integration branch from d7e0a60 to bd99d29 Compare July 28, 2026 14:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d7e0a606f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/package.json
"@radix-ui/react-tabs": "^1.1.13",
"@radix-ui/react-toggle": "^1.1.10",
"@radix-ui/react-tooltip": "^1.2.8",
"@shivai.space/world-view-react": "link:../../shivai/realm/packages/shivai-world-view-react",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid a sibling-only desktop dependency

In a clean Buzz checkout or CI/release runner, ../../shivai/realm/packages/shivai-world-view-react is not part of this repository and the desktop install steps use pnpm install --frozen-lockfile without checking out that sibling tree. That makes installs/builds fail before the new desktop UI can compile for anyone who does not have the private/local shivai checkout at exactly that relative path; vendor/publish this package or add it as a real workspace/submodule with matching CI setup.

Useful? React with 👍 / 👎.

"binaries/git-credential-nostr",
"binaries/buzz"
"binaries/buzz",
"binaries/shivai-world"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Bundle the new Shivai sidecar

Adding this externalBin makes Tauri look for a target-suffixed binary such as desktop/src-tauri/binaries/shivai-world-<target> (the Tauri config docs describe the binary-name{-target-triple}{.system-extension} lookup), but the repo's sidecar bundling script and CI placeholder steps still enumerate only buzz-acp, buzz-agent, buzz-dev-mcp, git-credential-nostr, and buzz. In clean CI/release runs this file is never created, so the Tauri build/package path fails or ships without the resolver; update the build/copy/stub steps for every target.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant