feat(world-views): integrate Shivai channel and thread views - #3318
feat(world-views): integrate Shivai channel and thread views#3318slava-class wants to merge 1 commit into
Conversation
Signed-off-by: prfndty <prfndty@shivai.space>
d7e0a60 to
bd99d29
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7e0a606f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@radix-ui/react-tabs": "^1.1.13", | ||
| "@radix-ui/react-toggle": "^1.1.10", | ||
| "@radix-ui/react-tooltip": "^1.2.8", | ||
| "@shivai.space/world-view-react": "link:../../shivai/realm/packages/shivai-world-view-react", |
There was a problem hiding this comment.
Avoid a sibling-only desktop dependency
In a clean Buzz checkout or CI/release runner, ../../shivai/realm/packages/shivai-world-view-react is not part of this repository and the desktop install steps use pnpm install --frozen-lockfile without checking out that sibling tree. That makes installs/builds fail before the new desktop UI can compile for anyone who does not have the private/local shivai checkout at exactly that relative path; vendor/publish this package or add it as a real workspace/submodule with matching CI setup.
Useful? React with 👍 / 👎.
| "binaries/git-credential-nostr", | ||
| "binaries/buzz" | ||
| "binaries/buzz", | ||
| "binaries/shivai-world" |
There was a problem hiding this comment.
Adding this externalBin makes Tauri look for a target-suffixed binary such as desktop/src-tauri/binaries/shivai-world-<target> (the Tauri config docs describe the binary-name{-target-triple}{.system-extension} lookup), but the repo's sidecar bundling script and CI placeholder steps still enumerate only buzz-acp, buzz-agent, buzz-dev-mcp, git-credential-nostr, and buzz. In clean CI/release runs this file is never created, so the Tauri build/package path fails or ships without the resolver; update the build/copy/stub steps for every target.
Useful? React with 👍 / 👎.
Summary
Adds one typed, channel/thread-scoped Shivai world-view boundary across the relay, CLI, desktop, and managed-agent prompt path.
40101with optimistic replacement semantics;worldCLI;Related issue
N/A — no matching open issue or PR found.
Testing
cargo test -p buzz-core -p buzz-world-view-resolver -p buzz-cli -p buzz-acp— 1,147 passed, 1 ignored.cargo test -p buzz-relay channel_scoped_content_kinds_require_h_tags -- --exact— passed.cargo test --manifest-path desktop/src-tauri/Cargo.toml -- --nocapture— 1,832 passed, 14 ignored.pnpm typecheck— passed.pnpm build:e2e— passed.pnpm exec playwright test tests/e2e/world-views.spec.ts— 10 passed..world, resolved its view catalog, rendered the binding editor, and verified an attacker-origin link stops at explicit trust consent with sharing disabled.The complete
buzz-relaysuite also ran: 766 tests passed and 33 were ignored, but the upstreamapi::mesh_demo::tests::demo_join_forwarded_arm_round_trips_echolocal-loopback test repeatedly returned 504 instead of 200 on this workstation. The world-view relay admission test above is green.