fix(acp): re-root custom log targets under buzz_acp - #3309
Open
troyhoffman-oss wants to merge 1 commit into
Open
fix(acp): re-root custom log targets under buzz_acp#3309troyhoffman-oss wants to merge 1 commit into
buzz_acp#3309troyhoffman-oss wants to merge 1 commit into
Conversation
The default filter is `buzz_acp=info` — set in `run()` and matched by the desktop's child-process filter — but 84 log sites across the message-handling path declare their own target: `pool::session`, `pool::prompt`, `acp::wire`, `canvas::fetch`, and a dozen more. `EnvFilter` matches a target by prefix from its root, and none of those roots is `buzz_acp`, so every one of them was filtered out. Turn dispatch, wire traffic, and session lifecycle have never appeared in a production journal, and `RUST_LOG=buzz_acp=debug` — the line `TESTING.md` hands operators when the default log is too quiet — turned none of them on. Each target is now prefixed with `buzz_acp::`, so the crate filter reaches them while the existing suffixes keep working as narrower selectors (`RUST_LOG=buzz_acp::acp::wire=trace`). Names are otherwise unchanged, and nothing outside these call sites referenced them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Troy Hoffman <troy.hoffman@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default filter is
buzz_acp=info— set inrun()and matched by the desktop's child-process filter inmanaged_agents/runtime.rs— but 84 log sites across the message-handling path declare their own target:pool::session,pool::prompt,acp::wire,canvas::fetch, and a dozen more.EnvFiltermatches a target by prefix from its root, and none of those roots isbuzz_acp, so every one of them is filtered out. Turn dispatch, wire traffic, and session lifecycle never appear in a production journal, andRUST_LOG=buzz_acp=debug— the lineTESTING.mdhands operators when the default log is too quiet — turns none of them on.This is the mechanism behind an observation in #2795: that fix's only trace was "a
pool::modelWARN that never reaches the per-agent log files."Each target is now prefixed with
buzz_acp::, so the crate filter reaches them while the existing suffixes keep working as narrower selectors (RUST_LOG=buzz_acp::acp::wire=trace). Names are otherwise unchanged, and nothing outside these call sites referenced them.Pure rename — 84 insertions, 84 deletions, every changed line a
target:string. No behavior change beyond the logs becoming reachable.Testing
cargo test -p buzz-acp --lib:616 passed; 0 failed.cargo fmt --checkandcargo clippy -p buzz-acp --all-targetsclean.