Skip to content

fix(desktop): gate codex-acp on a minimum supported version - #3254

Open
wpfleger96 wants to merge 1 commit into
mainfrom
duncan/codex-acp-version-gate
Open

fix(desktop): gate codex-acp on a minimum supported version#3254
wpfleger96 wants to merge 1 commit into
mainfrom
duncan/codex-acp-version-gate

Conversation

@wpfleger96

Copy link
Copy Markdown
Member

The codex adapter version gate accepted any major >= 1, so a 1.x codex-acp older than the version that fixes outbound relay access for buzz CLI subprocesses classified as Available and was never offered a reinstall. Only the 0.16.x @zed-industries/codex-acp adapter — which fails --version outright — was caught.

probe_codex_acp_version now returns the full (major, minor, patch) triple and codex_adapter_availability compares it against a new MIN_CODEX_ACP_VERSION floor of 1.1.7, the current npm latest. An adapter below the floor classifies as AdapterOutdated, which routes it through the existing uninstall-then-install reinstall plan.

The parse requires exactly three numeric dot-separated components. Partial versions (1.2) and prerelease tags (1.2.0-rc1) return None and therefore classify as AdapterOutdated — a version Buzz cannot compare against the floor fails closed, offering a reinstall rather than running an adapter of unknown vintage. Both the floor's bump policy and the strict-parse behavior are stated in doc comments rather than left implicit.

Supersedes #3097 by @Bharathchinneni, whose semver floor and behavior tests this carries. That PR could not land as written: the two probe_codex_acp_major_version compatibility wrappers it kept had no non-test callers, which is a hard clippy -D warnings failure. The wrappers are deleted here and their call sites collapsed onto probe_codex_acp_version.

The adapter version gate accepted any major >= 1, so a 1.x codex-acp
older than the version that fixes outbound relay access for buzz CLI
subprocesses classified as Available and was never offered a reinstall.

Probe the full (major, minor, patch) triple and compare it against
MIN_CODEX_ACP_VERSION. The parse requires exactly three numeric
components, so partial versions and prerelease tags fail closed as
AdapterOutdated rather than being assumed current.

Supersedes #3097 by Bharathchinneni.

Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
@wpfleger96
wpfleger96 requested a review from a team as a code owner July 28, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant