fix(desktop): gate codex-acp on a minimum supported version - #3254
Open
wpfleger96 wants to merge 1 commit into
Open
fix(desktop): gate codex-acp on a minimum supported version#3254wpfleger96 wants to merge 1 commit into
wpfleger96 wants to merge 1 commit into
Conversation
The adapter version gate accepted any major >= 1, so a 1.x codex-acp older than the version that fixes outbound relay access for buzz CLI subprocesses classified as Available and was never offered a reinstall. Probe the full (major, minor, patch) triple and compare it against MIN_CODEX_ACP_VERSION. The parse requires exactly three numeric components, so partial versions and prerelease tags fail closed as AdapterOutdated rather than being assumed current. Supersedes #3097 by Bharathchinneni. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codex adapter version gate accepted any
major >= 1, so a 1.xcodex-acpolder than the version that fixes outbound relay access forbuzzCLI subprocesses classified asAvailableand was never offered a reinstall. Only the 0.16.x@zed-industries/codex-acpadapter — which fails--versionoutright — was caught.probe_codex_acp_versionnow returns the full(major, minor, patch)triple andcodex_adapter_availabilitycompares it against a newMIN_CODEX_ACP_VERSIONfloor of1.1.7, the current npm latest. An adapter below the floor classifies asAdapterOutdated, which routes it through the existing uninstall-then-install reinstall plan.The parse requires exactly three numeric dot-separated components. Partial versions (
1.2) and prerelease tags (1.2.0-rc1) returnNoneand therefore classify asAdapterOutdated— a version Buzz cannot compare against the floor fails closed, offering a reinstall rather than running an adapter of unknown vintage. Both the floor's bump policy and the strict-parse behavior are stated in doc comments rather than left implicit.Supersedes #3097 by @Bharathchinneni, whose semver floor and behavior tests this carries. That PR could not land as written: the two
probe_codex_acp_major_versioncompatibility wrappers it kept had no non-test callers, which is a hardclippy -D warningsfailure. The wrappers are deleted here and their call sites collapsed ontoprobe_codex_acp_version.