Prevent stalled sink requests - #165
Merged
Merged
Conversation
Apply the existing retry send budget to in-flight calls and configure bounded HTTP transports so stalled sink requests return. Co-authored-by: Ian Oberst <ioberst@squareup.com> Signed-off-by: Ian Oberst <ioberst@squareup.com> Co-authored-by: Codex <noreply@openai.com> Ai-assisted: true
Areson
marked this pull request as ready for review
July 14, 2026 17:23
aparajon
approved these changes
Jul 14, 2026
felixp-square
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A blocked sink request can stall metric delivery indefinitely because the retry deadline was not propagated and sink HTTP clients had no whole-request timeout.
What
Risk Assessment
Medium — this changes shared Datadog and SignalFx HTTP client behavior. Requests that exceed the new 10-second ceiling will fail and retry instead of blocking indefinitely.
References
go test ./sink/... ./server/...go test ./monitor/...with the repository test MySQL servicecodex review --base main: no findingsGenerated with Codex