fix: dispatch NoResponse check before empty-Type guard (#116) - #122
Merged
Conversation
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The dispatch loop checks
Type == ""(empty envelope guard) before checkingNoResponse(streaming marker). Since chunked handlers returnEnvelope{NoResponse: true}with an empty Type, the dispatch firesErrUnhandledinstead of honoring NoResponse.Fix
Move the
NoResponsecheck above the empty-Type guard. NoResponse envelopes intentionally have an empty Type — the handler already wrote its own response viaWriteEnvelope.Also removes the duplicate NoResponse block that was sitting below the ID-echo guard.