fix: double final-chunk race — demuxer sends tail as intermediate, handler owns final (#116) - #120
Closed
blaspat wants to merge 11 commits into
Closed
fix: double final-chunk race — demuxer sends tail as intermediate, handler owns final (#116)#120blaspat wants to merge 11 commits into
blaspat wants to merge 11 commits into
Conversation
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
#116) Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
…#116) Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
…ns final (#116) Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Owner
Author
|
Superseded by #121 — clean branch from main with no conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The demuxer's
finish()was sending the tail output asmore=false(final chunk), then the handler was also sending amore=falsechunk with metadata. This caused a double-finalization race on the server — the firstmore=falseresolved the waiter, and the second hit a stale state.Fix
Demuxer now sends tail as
more=true(intermediate chunk). Only the handler sends the realmore=falsefinal chunk withexit_code,status,duration_ms, andtruncatedmetadata. Single source of truth for completion.Tested
go build ./...— cleango test ./... -count=1— all pass (except pre-existing flakyTestReconnect_RecoversAfterServerRestart)